Change default power to invite in private space + setting #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
added
A-Spaces
bmarty
requested changes
Sep 14, 2021
| @@ -77,7 +78,7 @@ internal class DefaultSpaceService @Inject constructor( | |||
| if (isPublic) { | |||
| this.roomAliasName = roomAliasLocalPart | |||
| this.powerLevelContentOverride = (powerLevelContentOverride ?: PowerLevelsContent()).copy( | |||
| invite = 0 | |||
| invite = if (isPublic) 0 else Role.Moderator.value | |||
There was a problem hiding this comment.
Can you use Role.Default.value instead of 0?
| @@ -70,7 +77,7 @@ sealed class EditablePermission(@StringRes val labelResId: Int) { | |||
|
|
|||
| class UpgradeTheRoom : EventTypeEditablePermission( | |||
| EventType.STATE_ROOM_TOMBSTONE, | |||
| R.string.room_permissions_upgrade_the_room | |||
| R.string.room_permissions_upgrade_the_space | |||
There was a problem hiding this comment.
I guess you wanted to write:
R.string.room_permissions_upgrade_the_room,
R.string.room_permissions_upgrade_the_space| if (params.isPublic) { | ||
| this.roomAliasName = params.spaceAlias | ||
| this.powerLevelContentOverride = (powerLevelContentOverride ?: PowerLevelsContent()).copy( | ||
| invite = 0 |
| this.guestAccess = GuestAccess.CanJoin | ||
| } else { | ||
| this.preset = CreateRoomPreset.PRESET_PRIVATE_CHAT | ||
| visibility = RoomDirectoryVisibility.PRIVATE |
There was a problem hiding this comment.
why this one does not have this.?
| @@ -25,4 +25,5 @@ sealed class SpaceManagedSharedAction : VectorViewModelAction { | |||
| object CreateRoom : SpaceManagedSharedAction() | |||
| object ManageRooms : SpaceManagedSharedAction() | |||
| object OpenSpaceAliasesSettings : SpaceManagedSharedAction() | |||
| object OpenRoomPermissionSettings : SpaceManagedSharedAction() | |||
There was a problem hiding this comment.
Maybe you have hesitated with OpenSpacePermissionSettings?
BillCarsonFr
force-pushed
the
feature/bca/spaces_fix_invite_private
branch
from
69cfb42
to
70ebb3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3951
Change default power level to invite in private room to 50 (Moderator)
Also adding settings UX to change it
